Andrea Cosentino created CAMEL-24363:
----------------------------------------
Summary: camel-aws: minor fixes - iam endpoint doStop, eks catalog
defaultValue, parameter-store value header
Key: CAMEL-24363
URL: https://issues.apache.org/jira/browse/CAMEL-24363
Project: Camel
Issue Type: Bug
Components: camel-aws
Reporter: Andrea Cosentino
Fix For: 4.22.0
Three small, independent defects found during the camel-aws review:
h3. 1. IAM2Endpoint.doStop() does not call super.doStop()
{{IAM2Endpoint.doStop()}} closes the IAM client but never calls
{{super.doStop()}}. Every other aws2 endpoint (including the paired
{{KMS2Endpoint}}) calls it, so the base
{{ScheduledPollEndpoint}}/{{DefaultEndpoint}} stop logic is skipped for IAM.
Fix: add {{super.doStop()}} as the last statement.
h3. 2. eks profileCredentialsName has a bogus defaultValue
{{EKS2Configuration.profileCredentialsName}} is a {{String}} annotated with
{{@UriParam(defaultValue = "false")}} - a copy-paste from the adjacent boolean
provider flags. It has no runtime effect but pollutes the generated catalog
with a misleading default for a profile-name string. ECS's equivalent field is
correct ({{@UriParam(label = "security")}}). Fix: match ECS and regenerate the
catalog.
h3. 3. parameter-store CamelAwsParameterStoreValue header is advertised but
never read
{{ParameterStoreConstants.PARAMETER_VALUE}} ({{CamelAwsParameterStoreValue}})
is annotated with {{@Metadata}} and published in the catalog as a producer
header, but no code path reads it - {{putParameter}} always takes the value
from the message body via {{getMandatoryBody(String.class)}}. Fix: honor the
header when present (falling back to the body), so the documented option works;
the common body-based flow is unchanged.
All three are low severity. Targeting main (4.22.0).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
