[
https://issues.apache.org/jira/browse/CAMEL-21690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922635#comment-17922635
]
Thomas Diesler commented on CAMEL-21690:
----------------------------------------
For export, we set
{code}
var skipPush = !container.getImagePush();
buildProperties.add("jkube.skip.push=%b".formatted(skipPush));
{code}
for run, we have
{code}
if (imagePush) {
args.add("-Djkube.%s.push=true".formatted(imageBuilder));
}
{code}
which is wrong and should be
{code}
if (imagePush) {
args.add("-Djkube.skip.push=false");
}
{code}
This bug was probably introduced when switching that property to JKube and went
unnoticed because we always set it explicitly.
Would you like me to look at this and test it against the matrix.
> camel-jbang - Image push option on Kubernetes run command not working
> ---------------------------------------------------------------------
>
> Key: CAMEL-21690
> URL: https://issues.apache.org/jira/browse/CAMEL-21690
> Project: Camel
> Issue Type: Bug
> Components: camel-jbang
> Affects Versions: 4.9.0
> Reporter: Christoph Deppisch
> Assignee: Christoph Deppisch
> Priority: Major
> Fix For: 4.10.0
>
>
> The Camel JBang Kubernetes run command provides the option to automatically
> push the built container image to the Kubernetes image registry
> (--image-push=true)
> This option has no effect. Even if set to true the exported project has the
> option
> {noformat}
> <jkube.skip.push>true</jkube.skip.push>{noformat}
> and the image push is skipped.
> Also, the --image-push option is set to false as a default value. I'd suggest
> to set this to true by default as almost all Kubernetes run commands need to
> push the container image. Otherwise the Kubernetes Deployment will not be
> able to pull the container image from the registry (on Minikube, Kind,
> OpenShift, etc.) and the deployment is failing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
