[ 
https://issues.apache.org/jira/browse/CAMEL-21313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886684#comment-17886684
 ] 

Otavio Rodolfo Piske commented on CAMEL-21313:
----------------------------------------------

Ideally, it should also:

1. replace lots of those concatenations in the routes with fromF as well. 
2. use assertDoesNotThrow instead of try/catch 

> camel-clickup: the tests are inadequately written and inconsistent
> ------------------------------------------------------------------
>
>                 Key: CAMEL-21313
>                 URL: https://issues.apache.org/jira/browse/CAMEL-21313
>             Project: Camel
>          Issue Type: Test
>          Components: camel-clickup
>    Affects Versions: 4.9.0
>            Reporter: Otavio Rodolfo Piske
>            Priority: Major
>
> The tests do too much. Ideally, each test should test one thing and only one.
> The actual test code should NOT: 
> 1. Setup the environment, routes or the test itself
> 2. Manage the context lifecycle (unless the context lifecycle is primarily 
> relevant to the test itself)
> 3. Should not isolate the test in an anonymous code block 
> Ideally, the test should do one thing and one thing only: assert that the 
> condition under test pass or fail. Everything else is either setup, cleanup 
> or management and should not be in the test method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to