[
https://issues.apache.org/jira/browse/CAMEL-19767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882747#comment-17882747
]
Gaelle Fournier commented on CAMEL-19767:
-----------------------------------------
[~orpiske] I fixed the ones from the original PR.
As for the ones still present, they are a result of common testing code used.
While the common code is very usefull in passing Unit Tests, they are not as
ideal for failing use cases. Removing the catching of AssertionError in a lot
of the existing usage would add more duplicate code.
WDYT ?
> camel-core: test should not catch AssertionError
> ------------------------------------------------
>
> Key: CAMEL-19767
> URL: https://issues.apache.org/jira/browse/CAMEL-19767
> Project: Camel
> Issue Type: Task
> Components: camel-core
> Reporter: Nikita_Konovalov
> Assignee: Gaelle Fournier
> Priority: Major
> Labels: help-wanted
> Fix For: 4.x
>
>
> ??Regarding the first set of changes ...??
> ??I think catching an {{AssertionError}} is not an adequate test practice.
> That deviates from the actual purpose of the AssertionError which is to
> indicate that the test has failed.??
> ??For now, let's keep the original as is. Let's create a ticket on Apache
> Jira to note that this is a bad practice that must be fixed.??
>
> Quoting [~orpiske]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
