[
https://issues.apache.org/jira/browse/CAMEL-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zineb Bendhiba updated CAMEL-20634:
-----------------------------------
Description:
While renaming the component (cf.
https://issues.apache.org/jira/browse/CAMEL-20611), I had to change the header
'CamelLangChainEmbeddingsVector' to 'CamelLangChain4jEmbeddingsVector' three
times: in 'langchain4j-embeddings', 'qdrant', and 'Milvus'.
If we don't extract this string into a common dependency and need to rename it
again, we will have to revisit multiple dependencies.
Perhaps it would be better to move it to the 'camel-api' module.
was:
while renaming the component (cf
https://issues.apache.org/jira/browse/CAMEL-20611) I had to rename the header
"CamelLangChainEmbeddingsVector", 3 times to
"CamelLangChain4jEmbeddingsVector". : in langchain4j-embeddings, qdrant and
Milvus.
If we don't get this string out in a common dependency, if we have to rename
another time, we will have to go again in multiple dependencies
Maybe move it camel-api module
> Have a central variable for the CamelLangChainEmbeddingsVector header name
> --------------------------------------------------------------------------
>
> Key: CAMEL-20634
> URL: https://issues.apache.org/jira/browse/CAMEL-20634
> Project: Camel
> Issue Type: New Feature
> Components: camel-langchain4j
> Affects Versions: 4.5.0
> Reporter: Zineb Bendhiba
> Assignee: Zineb Bendhiba
> Priority: Minor
> Fix For: 4.6.0
>
>
> While renaming the component (cf.
> https://issues.apache.org/jira/browse/CAMEL-20611), I had to change the
> header 'CamelLangChainEmbeddingsVector' to 'CamelLangChain4jEmbeddingsVector'
> three times: in 'langchain4j-embeddings', 'qdrant', and 'Milvus'.
> If we don't extract this string into a common dependency and need to rename
> it again, we will have to revisit multiple dependencies.
> Perhaps it would be better to move it to the 'camel-api' module.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
