[
https://issues.apache.org/jira/browse/CALCITE-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
krooswu updated CALCITE-7749:
-----------------------------
Description:
{{SqlTypeFamily.STRING}} is an aggregate family that covers both {{CHARACTER}}
and {{{}BINARY{}}}. Operators like {{CONCAT}} use
{{{}OperandTypes.STRING_SAME_SAME{}}}, which requires both operands to be in
the STRING family AND to be mutually comparable.
Repro:
sql
{{SELECT CONCAT('a', x'0a');}}
Actual error:
{{Cannot apply 'CONCAT' to arguments of type 'CONCAT(<CHAR(1)>, <BINARY(1)>)'.
Supported form(s): 'CONCAT(<STRING>, <STRING>)'}}
This is misleading: {{CONCAT}} _does_ accept {{BINARY}} arguments (e.g.
{{CONCAT(x'0a', x'0b')}} works fine), so the message reads as if BINARY support
were missing altogether, when the real constraint is that both arguments must
belong to the same concrete sub-family (both CHARACTER or both BINARY). The
"Supported form(s)" text should reflect this constraint instead of implying any
CHARACTER/BINARY mix is allowed.
was:
{{SqlTypeFamily.STRING}} is an aggregate family that covers both {{CHARACTER}}
and {{{}BINARY{}}}. Operators like {{CONCAT}} use
{{{}OperandTypes.STRING_SAME_SAME{}}}, which is defined as:
java
{{STRING_SAME_SAME = STRING_STRING.and(SAME_SAME);}}
{{STRING_STRING}} checks each operand independently against the aggregate
{{STRING}} family, so a {{CHAR}} argument and a {{BINARY}} argument each pass
on their own. The actual constraint that rejects mixed CHARACTER/BINARY calls
comes from the second, AND-composed rule, {{{}SAME_SAME{}}}, which requires the
operands to be mutually comparable (i.e. share the same _concrete_ family).
> CONCAT (and other STRING_SAME_SAME-typed operators) gives misleading error
> message for mixed CHARACTER/BINARY arguments
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-7749
> URL: https://issues.apache.org/jira/browse/CALCITE-7749
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.42.0
> Reporter: krooswu
> Assignee: krooswu
> Priority: Minor
> Fix For: 1.43.0
>
>
> {{SqlTypeFamily.STRING}} is an aggregate family that covers both
> {{CHARACTER}} and {{{}BINARY{}}}. Operators like {{CONCAT}} use
> {{{}OperandTypes.STRING_SAME_SAME{}}}, which requires both operands to be in
> the STRING family AND to be mutually comparable.
> Repro:
>
> sql
> {{SELECT CONCAT('a', x'0a');}}
> Actual error:
>
> {{Cannot apply 'CONCAT' to arguments of type 'CONCAT(<CHAR(1)>, <BINARY(1)>)'.
> Supported form(s): 'CONCAT(<STRING>, <STRING>)'}}
> This is misleading: {{CONCAT}} _does_ accept {{BINARY}} arguments (e.g.
> {{CONCAT(x'0a', x'0b')}} works fine), so the message reads as if BINARY
> support were missing altogether, when the real constraint is that both
> arguments must belong to the same concrete sub-family (both CHARACTER or both
> BINARY). The "Supported form(s)" text should reflect this constraint instead
> of implying any CHARACTER/BINARY mix is allowed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
