[ 
https://issues.apache.org/jira/browse/CALCITE-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18108795#comment-18108795
 ] 

Ruben Q L commented on CALCITE-7746:
------------------------------------

[~mbudiu] I managed to come up with an implementation for this, it requires a 
bit of extra "intelligence" on the SafeRexVisitor, but it should fix the 
problem. Please take a look when you have a bit of time.

> Review operation safety on arithmetic on dates and intervals
> ------------------------------------------------------------
>
>                 Key: CALCITE-7746
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7746
>             Project: Calcite
>          Issue Type: Task
>          Components: core
>            Reporter: Ruben Q L
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, arithmetic operations on dates and intervals do not have any 
> particular management (they are treated as any other operands).
> However, in this case arithmetic operations (even the standard, non-checked 
> ones) can throw at runtime, so they should probably be reviewed and not 
> considered "safe" in RexSimply.
> See disabled test with this ticket number in RexProgramTest.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to