[ 
https://issues.apache.org/jira/browse/CALCITE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106104#comment-18106104
 ] 

Mihai Budiu commented on CALCITE-7725:
--------------------------------------

I have filed CALCITE-7729 with an additional linq4j bug which hides exceptions.

> Review safety of checked arithmetic operators
> ---------------------------------------------
>
>                 Key: CALCITE-7725
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7725
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Ruben Q L
>            Assignee: Mihai Budiu
>            Priority: Major
>             Fix For: 1.43.0
>
>
> At the moment, some checked arithmetic operators (CHECKED_PLUS, 
> CHECKED_MINUS, CHECKED_TIMES, CHECKED_MINUS_PREFIX) are part of the 
> {{safeOps}} set in {{RexSimplify#SafeRexVisitor}}, i.e. they are considered 
> "safe" by {{RexSimplify#isSafeExpression}} .
> To be reviewed if these operations should be considered actually "safe", 
> since they can throw at runtime (in case of overflow), similarly to e.g. a 
> division by zero, which is considered "unsafe".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to