[
https://issues.apache.org/jira/browse/CALCITE-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mihai Budiu resolved CALCITE-7717.
----------------------------------
Fix Version/s: 1.43.0
Resolution: Fixed
Fixed in
[https://github.com/apache/calcite/commit/8d2e09316c495e15d762855309eb6335490e7019]
Thank you for your review @zzwqqq
> Add a Collect.isValid method to check type invariants
> -----------------------------------------------------
>
> Key: CALCITE-7717
> URL: https://issues.apache.org/jira/browse/CALCITE-7717
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.42.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.43.0
>
>
> The isValid method is supposed to check invariants for subclasses of
> AbstractRelNode.
> Collect does not have such a method.
> While working on solving some bugs I have discovered that some rewrites
> produce malformed Collect nodes after validation, yet the plans do not reject
> them. Adding this validation would enable us to catch such bugs sooner.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
