[ 
https://issues.apache.org/jira/browse/CALCITE-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102772#comment-18102772
 ] 

Yu Xu commented on CALCITE-7693:
--------------------------------

[~krooswu] You helped review this previous PR before, could you please help 
review it again? very thanks!

> Move MongoDB LIKE-to-regex conversion into runtime.Like for consistency
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-7693
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7693
>             Project: Calcite
>          Issue Type: Improvement
>          Components: mongodb-adapter
>    Affects Versions: 1.42.0
>            Reporter: Yu Xu
>            Assignee: Yu Xu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.43.0
>
>
> Follow-up to the initial MongoDB LIKE 
> support(https://issues.apache.org/jira/browse/CALCITE-7673). In review it was 
> noted that the SQL-LIKE-to-regex conversion logic embedded in MongoFilter 
> duplicated a pattern Calcite already establishes in 
> org.apache.calcite.runtime.Like (see Like.sqlToRegexLike). Keeping the 
> conversion inside the adapter meant a second, independently-maintained 
> escape/wildcard translator with its own special-character table and error 
> handling.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to