[
https://issues.apache.org/jira/browse/CALCITE-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18034427#comment-18034427
]
Zhen Chen commented on CALCITE-7258:
------------------------------------
Yes, I should add a "should". The example is essentially what is described in
CALCITE-6448. During the process from SQL to RelNode, the creation of a Filter
includes checks to ensure the condition is of boolean type. However, if the
RelNode is constructed directly using the create method or via RelBuilder,
there is no validation logic requiring a boolean type, as this check only
exists at the SqlNode level. Perhaps the tests in RelBuilderTest from the PR
can illustrate this? Essentially, what I did, as you mentioned in CALCITE-6448,
is to make the validation of Filter stricter.
> Filters created in the RelBuilder maintain semantic consistency with the
> SqlNode level
> --------------------------------------------------------------------------------------
>
> Key: CALCITE-7258
> URL: https://issues.apache.org/jira/browse/CALCITE-7258
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.40.0
> Reporter: Zhen Chen
> Assignee: Zhen Chen
> Priority: Minor
> Labels: pull-request-available
>
> As discussed in CALCITE-6448, the creation of a Filter in RelBuilder has been
> updated to validate that the condition is of Boolean type. This change aligns
> the logic at the RelNode level with that at the SqlNode level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
