[ 
https://issues.apache.org/jira/browse/CALCITE-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18034212#comment-18034212
 ] 

Julian Hyde commented on CALCITE-7256:
--------------------------------------

Adding public methods without javadoc? What are you thinking. 

I don’t know what similar classes do, but since the fields are final I would 
just make them public (with javadoc). No need for getters. 

> Add getters for SqlTableRef
> ---------------------------
>
>                 Key: CALCITE-7256
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7256
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.41.0
>            Reporter: zhuyufeng
>            Assignee: zhuyufeng
>            Priority: Minor
>              Labels: pull-request-available
>
> When traversing SqlNode, accessing the fields in SqlTableRef is not 
> straightforward; therefore, it is desired to add getters for these fields.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to