[ 
https://issues.apache.org/jira/browse/CALCITE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023416#comment-18023416
 ] 

Julian Hyde commented on CALCITE-7205:
--------------------------------------

I don’t agree with your decision to remove code from RelNetadataTest to 
FunctionalDependecyIntegratuinTest. The behavior through the RekMetadata API is 
the important behavior, and that should drive everything else. 



I think there could,d be a better name than FunctionslDdpenecy for the core 
data structure. Functions, dependency describes the general field (like 
“calculus”) but isn’t really an entity. I think a language like “(a, b) -> c” 
(read “determines”) should be at the center of this. Every method should give 
at least one example using this notation. You shouldn’t define notions like 
closure without giving examples. 



Note that “determines” is a verb. That’s why we’re having trouble finding a 
name for the entities involved here. 



sorry about the typos. I am traveling and therefore typing into an iPad. 

> Implement Core FD Algorithm Library for Functional Dependencies
> ---------------------------------------------------------------
>
>                 Key: CALCITE-7205
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7205
>             Project: Calcite
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.40.0
>            Reporter: Zhen Chen
>            Assignee: Zhen Chen
>            Priority: Minor
>
> This JIRA primarily provides foundational capabilities for *relational 
> algebra and metadata reasoning*.
> *Main Implementations:*
> * Encapsulates functional dependency (FD) sets, supporting basic operations 
> such as addition, deletion, and query.
> * Provides algorithms for closure computation, minimal cover, equivalence 
> judgment, and candidate key discovery.
> * Supports efficient attribute reasoning and dependency reasoning, 
> facilitating use by upper-layer optimizers and metadata modules.
> Please refer to the discussion in the PR for [more 
> details|https://github.com/apache/calcite/pull/4540#discussion_r2384265382].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to