[ 
https://issues.apache.org/jira/browse/CALCITE-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mihai Budiu resolved CALCITE-7216.
----------------------------------
    Resolution: Fixed

Fixed in 
[https://github.com/apache/calcite/commit/51d617dbf80c2a67582fa6529be81c0c722716a4]

Thank you for the reviews [~asolimando] [~jensen]

> SqlOperator.inferReturnType throws the wrong exception on error
> ---------------------------------------------------------------
>
>                 Key: CALCITE-7216
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7216
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.40.0
>            Reporter: Mihai Budiu
>            Assignee: Mihai Budiu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.41.0
>
>
> This code fragment:
> {code:java}
>       RelDataType returnType = returnTypeInference.inferReturnType(opBinding);
>       if (returnType == null) {
>         throw new IllegalArgumentException("Cannot infer return type for "
>             + opBinding.getOperator() + "; operand types: "
>             + opBinding.collectOperandTypes());
>       }
> {code}
> throws IllegalArgumentException. I think it should throw a 
> CalciteContextException.
> Exceptions that are not CalciteExceptions should be used only to signal bugs 
> in the compiler, but not illegal input programs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to