[ 
https://issues.apache.org/jira/browse/CALCITE-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013367#comment-18013367
 ] 

Yu Xu commented on CALCITE-7119:
--------------------------------

While this is true, it's a bit strange that other components, like Hive, would 
need to rely on a third-party component like Calclite for their supported 
functions. If the Hive version changes, for example, to support more functions, 
Calcite would also need to be modified accordingly.

 However, the issue itself is completely clear, and I think this JIRA can be 
closed.

> The Dialect module does not require the supportsFunction interface
> ------------------------------------------------------------------
>
>                 Key: CALCITE-7119
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7119
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Yu Xu
>            Assignee: Yu Xu
>            Priority: Minor
>              Labels: pull-request-available
>
> *This is a regular minor-fix issue:*
> The Dialect.supportsFunction interface is not currently called anywhere, 
> although it is inherited by some subclasses.
> Currently, only supportFunctions in the Dialect interface has no meaning and 
> will affect the judgment of future Calcite developers. Therefore, it may be 
> appropriate to delete this interface.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to