[
https://issues.apache.org/jira/browse/CALCITE-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17980144#comment-17980144
]
Julian Hyde edited comment on CALCITE-7058 at 6/17/25 4:00 PM:
---------------------------------------------------------------
In my opinion, {{Decorrelator}} is broken and can't be fixed. We should be
investing in the decorrelation rules instead, and I think we should deprecate
{{Decorrelator}}.
(If we don't deprecate {{Decorrelator}}, how should we respond to issues like
CALCITE-7057, which are likely to be duplicates of issues filed years ago that
were never fixed?)
I am glad to see that CALCITE-7023 does not touch code outside of
{{Decorrelator}}. But ideally it would add Quidem tests that can be used to
check both implementations of decorrelation.
was (Author: julianhyde):
In my opinion, {{Decorrelator}} is broken and can't be fixed. We should be
investing in the decorrelation rules instead, and I think we should deprecate
{{Decorrelator}}.
I am glad to see that CALCITE-7023 does not touch code outside of
{{Decorrelator}}. But ideally it would add Quidem tests that can be used to
check both implementations of decorrelation.
> Decorrelator may produce different column names
> -----------------------------------------------
>
> Key: CALCITE-7058
> URL: https://issues.apache.org/jira/browse/CALCITE-7058
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.40.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
>
> In [CALCITE-7024] I have introduced an assertion (Litmus) check in the
> decorrelator that the output relation type is identical to the input relation
> type. This assertion is too strong, because the decorrelator sometimes
> produces different column names in the result.
> This may be a bug, but in the meantime it can be side-stepped by making the
> check a bit weaker: the types are identical up to column names.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
