[
https://issues.apache.org/jira/browse/CALCITE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939593#comment-17939593
]
Yu Xu edited comment on CALCITE-6929 at 3/31/25 8:42 AM:
---------------------------------------------------------
Currently seems not contains such test case for Presto, such as floor logical
handle, if PG's add a behavior change would impact presto at the same time( if
user not test in presto), IMO here not use PG is better and keep presto single
behavior? If really comfirm not need then I would close the issue and PR.
[~nobigo]
was (Author: JIRAUSER307770):
Currently seems not contains such test case for Presto, such as floor logical
handle, if PG's behavior change would impact presto at the same time( if user
not test in presto), IMO here not use PG is better and keep presto single
behavior? If really comfirm not need then I would close the issue and PR.
[~nobigo]
> PrestoSqlDialect unparseCall should not reuse from PostgreSqlDialect
> --------------------------------------------------------------------
>
> Key: CALCITE-6929
> URL: https://issues.apache.org/jira/browse/CALCITE-6929
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.39.0
> Reporter: Yu Xu
> Assignee: Yu Xu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.40.0
>
>
> Currently PrestoSqlDialect#unparseCall default condition reuse
> PostgreSqlDialect directly which would handle with floor function, it is not
> suitable when PostgreSqlDialect change in future but not consistent with
> Presto would bring risk in compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
