[
https://issues.apache.org/jira/browse/CALCITE-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936267#comment-17936267
]
Julian Hyde edited comment on CALCITE-6898 at 3/17/25 6:15 PM:
---------------------------------------------------------------
I don't think "description in PR" is adequate description of a case. If this is
a bug, you should be able to describe the problem and provide a test case.
In Calcite, our practice is to have substantive discussions in Jira, not in
PRs. PRs are fine for code-level discussions, but the goal, design
specification, and design discussion should be in Jira. To understand how the
system will be improved by merging the PR, it should be sufficient to read the
Jira only. My personal practice is to not even read the PR until the Jira
describes the problem to be solved.
Also, can you be sure to link related Jira cases. If you do this, perhaps it
will not even be necessary for this Jira case to link to a PR of a different
Jira case.
was (Author: julianhyde):
I don't think "description in PR" is adequate description of a case. If this is
a bug, you should be able to describe the problem and provide a test case.
> Unify simplify to simplifyUnknownAsFalse in splitFilter
> -------------------------------------------------------
>
> Key: CALCITE-6898
> URL: https://issues.apache.org/jira/browse/CALCITE-6898
> Project: Calcite
> Issue Type: Improvement
> Reporter: suibianwanwan
> Priority: Major
> Labels: pull-request-available
>
> Discussion in [PR|[https://github.com/apache/calcite/pull/4078]].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
