[
https://issues.apache.org/jira/browse/CALCITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921699#comment-17921699
]
Istvan Toth edited comment on CALCITE-5136 at 1/28/25 11:48 AM:
----------------------------------------------------------------
There are internal deprecation warnings for the *Configurable HTTP Client
interfaces, which are no longer implemented by anything.
Those either need to be un-implemented, or we need to suppress their uses
internally.
SPNEGO authentication is also deprecated without replacement in
apache-httpclient.
There are a few others, but those are trivial to fix.
was (Author: stoty):
There are internal deprecation warning for the *Configurable HTTP Client
interfaces, which are no longer implemented by anything.
Those either need to be un-implemented, or we need to suppress their uses
internally.
SPNEGO authentication is also deprecated without replacement in
apache-httpclient.
There are a few others, but those are trivial to fix.
> Avatica build (or CI) must fail if there are deprecation warnings
> -----------------------------------------------------------------
>
> Key: CALCITE-5136
> URL: https://issues.apache.org/jira/browse/CALCITE-5136
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Benchao Li
> Priority: Major
> Fix For: avatica-1.26.0
>
>
> Avatica build (or CI) must fail if there are deprecation warnings.
> The build currently gives the following warnings on JDK 18:
> {noformat}
> core/src/main/java/org/apache/calcite/avatica/remote/DoAsAvaticaHttpClient.java:37:
> warning: [removal] <T>doAs(Subject,PrivilegedAction<T>) in Subject has been
> deprecated and marked for removal
> return Subject.doAs(kerberosUtil.getSubject(), new
> PrivilegedAction<byte[]>() {
> ^
> where T is a type-variable:
> T extends Object declared in method <T>doAs(Subject,PrivilegedAction<T>)
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 1 warning
> > Task :server:compileJava
> server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:19:
> warning: [removal] AccessController in java.security has been deprecated and
> marked for removal
> import java.security.AccessController;
> ^
> server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java:204:
> warning: [removal] <T>doAs(Subject,PrivilegedAction<T>) in Subject has been
> deprecated and marked for removal
> Subject.doAs(subject, new PrivilegedAction<Void>() {
> ^
> where T is a type-variable:
> T extends Object declared in method <T>doAs(Subject,PrivilegedAction<T>)
> server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:43:
> warning: [removal] AccessController in java.security has been deprecated and
> marked for removal
> Subject subject = Subject.getSubject(AccessController.getContext());
> ^
> server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:43:
> warning: [removal] getSubject(AccessControlContext) in Subject has been
> deprecated and marked for removal
> Subject subject = Subject.getSubject(AccessController.getContext());
> ^
> server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:46:
> warning: [removal] <T>doAs(Subject,PrivilegedAction<T>) in Subject has been
> deprecated and marked for removal
> return Subject.doAs(subject, new PrivilegedAction<Thread>() {
> ^
> where T is a type-variable:
> T extends Object declared in method <T>doAs(Subject,PrivilegedAction<T>)
> server/src/main/java/org/apache/calcite/avatica/server/SubjectPreservingPrivilegedThreadFactory.java:44:
> warning: [removal] AccessController in java.security has been deprecated and
> marked for removal
> return AccessController.doPrivileged(new PrivilegedAction<Thread>() {
> {noformat}
> I believe these warnings were introduced in CALCITE-5095.
> Must fix before 1.22. We can't allow broken windows in the build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
