[ 
https://issues.apache.org/jira/browse/CALCITE-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896782#comment-17896782
 ] 

Julian Hyde commented on CALCITE-6680:
--------------------------------------

I understand. But now we are in the unfortunate situation of reviewing a commit 
that seems to be authored by [~mbudiu] that was actually partially authored by 
you.

Mihai should have pushed back and said "We need a PR".

For future reference.

> RexImpTable erroneously declares NullPolicy.NONE for IS_EMPTY
> -------------------------------------------------------------
>
>                 Key: CALCITE-6680
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6680
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Chris Dennis
>            Assignee: Mihai Budiu
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: is-empty-nullable.patch
>
>
> RexImpTable implements {{IS EMPTY}} and {{IS NOT EMPTY}} using 
> {{Collections.isEmpty()}} but declares them as {{NullPolicy.NONE}}. ThisĀ 
> causes nullable array and map columns to throw NPE at execution time when 
> hitting null values. I strongly suspect that other collection operators are 
> similarly misclassified and would run in to issues is used against nullable 
> types.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to