[
https://issues.apache.org/jira/browse/CALCITE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-6598.
----------------------------------
Fix Version/s: 1.38.0
Resolution: Fixed
Fixed in
[d59871d4|https://github.com/apache/calcite/commit/d59871d49cba28096b698efda80957ecc9e8c4ab];
which will be in release 1.38.
We will need to revisit this case after 1.38, so that in 1.39 Calcite does not
call the methods {{getMaxNumericScale}} or {{getMaxNumericPrecision}}, even in
user-supplied implementations of {{RelDataTypeSystem}}.
> In RelDataTypeSystem, deprecate methods getMaxNumericScale and
> getMaxNumericPrecision
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-6598
> URL: https://issues.apache.org/jira/browse/CALCITE-6598
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Priority: Major
> Fix For: 1.38.0
>
>
> In {{{}interface RelDataTypeSystem{}}}, deprecate {{getMaxNumericScale()}} in
> favor of {{getMaxScale(SqlTypeName)}} and {{getMaxNumericPrecision()}} in
> favor of {{{}getMaxPRecision(SqlTypeName){}}}.
> This will make them consistent with {{getMinScale(SqlTypeName)}} and
> {{getMinPrecision(SqlTypeName)}} (both added in CALCITE-6560).
> For each pair of methods (one with {{SqlTypeName}} and one without), if we
> allow people to choose which to override, things will become too complicated.
> So, in release 1.39 we will make {{getMaxNumericScale()}} and
> {{getMaxNumericPrecision()}} methods final (in addition to being deprecated
> as of release 1.38). People should only override {{getMaxScale(SqlTypeName)}}
> and {{{}getMaxPrecision(SqlTypeName){}}}.
> This will be a *breaking change* in 1.39 -- projects that have overridden
> these methods will be broken – but at least we will have given them one
> release warning.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
