[
https://issues.apache.org/jira/browse/CALCITE-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883940#comment-17883940
]
James Duong commented on CALCITE-6465:
--------------------------------------
I'd say the two areas where circular dependencies are a concern are:
* the relation between CalciteSystemProperty/calcite-core and linq4j. I didn't
introduce a circular dependency here, but there's more explicit checking of the
new property than I'd like and also one place in linq4j where the parameter
isn't looked up. We could mitigate this by creating another module that
calcite-core and linq4j both depend on and moving CalciteSystemProperty there.
* The Flink project and Calcite projects themselves:
** The Flink developers
[mentioned|https://lists.apache.org/thread/qgh4hxjrqpz920orv0b7f5w3hvv7vhyd]
that the only Calcite dependencies they have are on modules we aren't
importing: {_}flink-connector-hive, flink-sql-parser, flink-sql-client,
flink-table-calcite-bridge, flink-table-planner{_}. They've also mentioned that
method-splitting is intended to be re-used in multiple projects so they
designed it to be fairly self-contained.
** Still, it is a bit awkward to, at the project-level, have a circular
relationship between the two. I don't see a way to avoid this without getting
agreement to spin-off the method-splitting module into its own project.
> Rework code generator to use Flink code splitter
> ------------------------------------------------
>
> Key: CALCITE-6465
> URL: https://issues.apache.org/jira/browse/CALCITE-6465
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: James Duong
> Assignee: James Duong
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.38.0
>
>
> Holistically replace the (or provide a separate optional) code generator to
> reduce issues such as CALCITE-3094 .
> One suggestion in the comments for CALCITE-3094 has been to use the [code
> generator from
> Flink.|https://nightlies.apache.org/flink/flink-docs-release-1.3/api/java/org/apache/flink/table/codegen/CodeGenerator.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
