[ 
https://issues.apache.org/jira/browse/CALCITE-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cyril de Catheu updated CALCITE-6466:
-------------------------------------
    Description: 
*Summary:*
Sql Parsers instantiation is slow because it instantiates a Throwable with a 
stacktrace.
The speed of instantiation also depends on the call stack depth at the time of 
instantiation. The deeper in the call stack, the slower the instantiation.

*Analysis:*
This is an issue caused by JavaCC. The issue is fixed in newer version of 
JavaCC.
Once JavaCC is upgraded to 7.0.13 
(https://issues.apache.org/jira/browse/CALCITE-5541), this benchmark can be 
re-run.
See full discussion here: 
[https://lists.apache.org/thread/xw35sdy1w1k8lvn1q1lr7xb93bkj0lpq]

{*}TODO{*}:
Add a benchmark to measure the evolution of this issue. 
The benchmark can be re-run once 
https://issues.apache.org/jira/browse/CALCITE-5541 is done.

Expected improvements are:
 - a minor speed improvement of ~10% for all parsers impacted by the issue
 - the instantiation of parsers should not depend on the call stack depth 
anymore

  was:
*Summary: *
Sql Parsers instantiation is slow because it instantiates a Throwable with a 
stacktrace.
The speed of instantiation also depends on the call stack depth at the time of 
instantiation. The deeper in the call stack, the slower the instantiation.

*Analysis:*
This is an issue caused by JavaCC. The issue is fixed in newer version of 
JavaCC.
Once JavaCC is upgraded to 7.0.13 
(https://issues.apache.org/jira/browse/CALCITE-5541), this benchmark can be 
re-run.
See full discussion here: 
https://lists.apache.org/thread/xw35sdy1w1k8lvn1q1lr7xb93bkj0lpq

*TODO*:
Add a benchmark to measure the evolution of this issue. 
The benchmark can be re-run once 
https://issues.apache.org/jira/browse/CALCITE-5541 is done.

Expected improvements are:
- a minor speed improvement of ~10% for all parsers impacted by the issue
- the instantiation of parsers should not depend on the call stack depth anymore


> Sql Parsers instantiation is slow
> ---------------------------------
>
>                 Key: CALCITE-6466
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6466
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Cyril de Catheu
>            Priority: Minor
>
> *Summary:*
> Sql Parsers instantiation is slow because it instantiates a Throwable with a 
> stacktrace.
> The speed of instantiation also depends on the call stack depth at the time 
> of instantiation. The deeper in the call stack, the slower the instantiation.
> *Analysis:*
> This is an issue caused by JavaCC. The issue is fixed in newer version of 
> JavaCC.
> Once JavaCC is upgraded to 7.0.13 
> (https://issues.apache.org/jira/browse/CALCITE-5541), this benchmark can be 
> re-run.
> See full discussion here: 
> [https://lists.apache.org/thread/xw35sdy1w1k8lvn1q1lr7xb93bkj0lpq]
> {*}TODO{*}:
> Add a benchmark to measure the evolution of this issue. 
> The benchmark can be re-run once 
> https://issues.apache.org/jira/browse/CALCITE-5541 is done.
> Expected improvements are:
>  - a minor speed improvement of ~10% for all parsers impacted by the issue
>  - the instantiation of parsers should not depend on the call stack depth 
> anymore



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to