[
https://issues.apache.org/jira/browse/CALCITE-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700328#comment-17700328
]
Sergey Nuyanzin commented on CALCITE-5567:
------------------------------------------
There an issue with such approach
The recommendation from jdk is usage of {{Locale.forLanguageTag}} [1] which is
based on RFC 5646.
The problem is that among others
{{org.apache.calcite.util.UtilTest#testParseLocale}} tests {{_GB}} as input[2]
which does not satisfy it.
And {{Locale.forLanguageTag}} considers it as an empty locale.
So either we break this or go with {{-Pwerror=false}}
Or did I miss anything
[1] https://github.com/openjdk/jdk/pull/7947
[2]
https://github.com/apache/calcite/blob/052a5cc724a889edf19c1d76ea166c0d0924a5d3/core/src/test/java/org/apache/calcite/util/UtilTest.java#L902-L922
> Failed to apply plugin 'de.thetaphi.forbiddenapis' when running ./gradlew
> build w/ java19
> -----------------------------------------------------------------------------------------
>
> Key: CALCITE-5567
> URL: https://issues.apache.org/jira/browse/CALCITE-5567
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.33.0
> Environment: {{OS: arch linux}}
> {{JDK: java-19-openjdk}}
> Reporter: Matt P
> Priority: Major
> Labels: pull-request-available
> Attachments: build.gradle.kts, output.txt
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Running {{./gradlew build}} on a fresh {{git clone}} fails with:
> {code:java}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/home/user/github/apache/calcite/build.gradle.kts' line: 513
> * What went wrong:
> Failed to apply plugin 'de.thetaphi.forbiddenapis'.
> > Could not create plugin of type 'ForbiddenApisPlugin'.
> > Could not initialize class
> de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin
> {code}
> The full output (output.txt) and {{build.gradle.kts}} files are attached.
> This is similar to https://issues.apache.org/jira/browse/SOLR-14426 but
> running {{./gradlew clean}} results in the same error.
> I've tried this on version 1.33 plus several older releases with similar
> results.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
