[ 
https://issues.apache.org/jira/browse/CALCITE-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636837#comment-17636837
 ] 

Julian Hyde commented on CALCITE-5360:
--------------------------------------

Oops, I had it backwards. {{DATEADD}} (defined in {{SqlLibraryOperators}}) maps 
onto {{TIMESTAMPADD}} (defined in the {{TIMESTAMP_ADD}} field in 
{{SqlStdOperatorTable}}), and so should {{TIMESTAMP_ADD}}.

The '_' in the name of the field {{SqlStdOperatorTable.TIMESTAMP_ADD}} is a bit 
confusing, but it's too late to change now.

> Implement BigQuery TIMESTAMP_ADD and TIMESTAMP_DIFF
> ---------------------------------------------------
>
>                 Key: CALCITE-5360
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5360
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>            Reporter: TJ Banghart
>            Assignee: TJ Banghart
>            Priority: Major
>
> Calcite already supports TIMESTAMPADD and TIMESTAMPDIFF. We should try 
> mapping the BQ style syntax to these already implemented functions.
> We did something similar for TIMESTAMP_TRUNC and TIME_TRUNC which 
> conveniently mapped to FLOOR in 
> [CALCITE-5269|https://issues.apache.org/jira/browse/CALCITE-5269]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to