[ 
https://issues.apache.org/jira/browse/CALCITE-5352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628024#comment-17628024
 ] 

Julian Hyde commented on CALCITE-5352:
--------------------------------------

It's reasonable that Calcite should support syntax like the following examples, 
which are valid in Postgres:
{code}
date_part('hour', timestamp '2001-02-16 20:38:40')
date_part('month', interval '2:3' year to month)
date_trunc('hour', timestamp '2001-02-16 20:38:40')
{code}

After CALCITE-5155 (which is almost ready) this should be an easier fix, 
because we now encode the time frame argument as an identifier.

Also related is CALCITE-5363 (move DATE_PART to core parser), but this case 
could happen before or after.

> Babel parser does not recognize character literal with DATE_PART function
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-5352
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5352
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: carton.swing
>            Priority: Major
>
> While using babel parser(calcite-babel's SqlBabelParserImpl) to parse 
> PostgreSQL syntax:
> {code:java}
> planner.parse("SELECT DATE_PART('week', TIMESTAMP '2022-10-31')"){code}
> it will throws exception.
> But if I use:
> {code:java}
> planner.parse("SELECT DATE_PART(week, TIMESTAMP '2022-10-31')"){code}
> the parser works well.
>  
> However, the former syntax, which is a quote-string, is correct according to 
> : [https://www.postgresql.org/docs/9.1/functions-datetime.html]
> |Note that here the {{field}} parameter needs to be a string value, not a 
> name. The valid field names for {{date_part}} are the same as for 
> {{{}extract{}}}.
> SELECT date_part('day', TIMESTAMP '2001-02-16 20:38:40');|
> The first argument should be a quote string instead of a TimeUnit token.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to