[
https://issues.apache.org/jira/browse/CALCITE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627397#comment-17627397
]
Julian Hyde commented on CALCITE-5358:
--------------------------------------
"core" and "remote" are separate gradle modules (and become separate jar files
at run time). There is a one-way dependency, and therefore code in "remote" can
see code in "core" but not vice versa.
You can't add a dependency (because that would make the dependency cyclic), nor
can you reverse it.
It probably makes sense to write the test in core, as you are doing. But then
you'll have to use a handler implementation that exists in core (either
core/src/main or core/src/test). I notice that {{AbstractHandlerTest}} uses
{{Mockito.mock}} in a few places. Could you use a similar mocking strategy?
> Adding in HTTP_BAD_REQUEST error response
> -----------------------------------------
>
> Key: CALCITE-5358
> URL: https://issues.apache.org/jira/browse/CALCITE-5358
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Oliver Lee
> Assignee: Oliver Lee
> Priority: Trivial
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{createErrorResponse}} function in {{AstractHandler.java}}
> [here|https://github.com/apache/calcite-avatica/blob/1f0f0c1c56b35c4524564a126f1db525437a130b/core/src/main/java/org/apache/calcite/avatica/remote/AbstractHandler.java#L126]
> doesn't include {{{}HTTP_BAD_REQUEST{}}}.
>
> An example use case is if an auth token as well as user/password is provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
