[ 
https://issues.apache.org/jira/browse/CALCITE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558186#comment-17558186
 ] 

Julian Hyde commented on CALCITE-5197:
--------------------------------------

1. When we upgrade Gradle, we need to change the version in the howto. (See 
CALCITE-4575 for why this is necessary.) Please make that change. 

2. It is my understanding that the Gradle wrapper needs to be updated much less 
frequently than Gradle. This change seems to encourage people to update the 
wrapper more frequently. Is that what we want? In my opinion, we should only 
upgrade the wrapper when necessary.

3. I think that howto should include sections "How to upgrade Gradle" and "How 
to upgrade the Gradle wrapper". If you agree, can you add them.

> Bump gradle to 7.4.2 and add checksum autoupdate
> ------------------------------------------------
>
>                 Key: CALCITE-5197
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5197
>             Project: Calcite
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.30.0
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Trivial
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The problem with gradle update via
> {code}
> ./gradlew wrapper --gradle-version <new_version> && ./gradlew autostyleApply
> {code}
> it removes checksum from {{gradle/wrapper/gradle-wrapper.properties}}
> there could be added a task which could update checksum as well, e.g.
> {code}
> tasks.wrapper {
>     distributionType = Wrapper.DistributionType.BIN
>     doLast {
>         val sha256Uri = URI("$distributionUrl.sha256")
>         val sha256Sum = String(sha256Uri.toURL().readBytes())
>         propertiesFile.appendText("distributionSha256Sum=${sha256Sum}\n")
>     }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to