[ 
https://issues.apache.org/jira/browse/CALCITE-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520890#comment-17520890
 ] 

xiong duan commented on CALCITE-5027:
-------------------------------------

Fixed in 
[bb90457|https://github.com/apache/calcite/commit/bb90457051f85930004e1f4bc23148efc672ef1c].
 Thanks for the review [~asolimando] and [~rubenql] .

> Incorrect format for timestamp literals in SqlDialect#quoteTimestampLiteral
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-5027
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5027
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Gregory Hart
>            Assignee: xiong duan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.31.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The SqlDialect#quoteTimestampLiteral method uses the wrong format for 
> standard SQL. Instead of "day of month" it uses "day of year", and instead of 
> seconds is uses milliseconds. To fix this method, the format should be 
> changed to: 
> yyyy-MM-dd HH:mm:ss



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to