[ 
https://issues.apache.org/jira/browse/CALCITE-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde resolved CALCITE-4925.
----------------------------------
    Resolution: Fixed

Fixed in 
[ecbafbfb|https://github.com/apache/calcite/commit/ecbafbfbd356955db08e363b71c03d8923e6fe98].
 Thanks for the PR, [~wnoble]!

> AggregateReduceFunctionsRule should accept arbitrary predicates
> ---------------------------------------------------------------
>
>                 Key: CALCITE-4925
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4925
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Will Noble
>            Assignee: Will Noble
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.29.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{AggregateReduceFunctionsRule}} allows you to specify which functions to 
> reduce, but only allows you to specify by function type. For instance, you 
> can either reduce all {{SUM}} functions, or no {{SUM}} functions, but not a 
> subset of {{SUM}} functions (say, only the {{SUM}} functions with distinct 
> keys). Allowing the user to specify an arbitrary predicate would allow us to 
> selectively apply the rule to functions without distinct keys, which matters 
> in Looker due to the fact that distinct keys cause an aggregate to be 
> impossible to roll up, and when that's the case, we'd like to avoid reducing 
> the functions for the purpose of aggregate awareness.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to