[ 
https://issues.apache.org/jira/browse/CALCITE-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452655#comment-17452655
 ] 

Julian Hyde edited comment on CALCITE-4915 at 12/2/21, 11:34 PM:
-----------------------------------------------------------------

{quote}But I think we should also change "expandCommonColumn" to non-static to 
match other "expand" methods semantic, WDYT?{quote}

It sounds logical, but there is a CheckerFramework check that will complain if 
you make a private method non-static that could be static. So don't do it.


was (Author: julianhyde):
{quote}But I think we should also change {{expandCommonColumn}} to non-static 
to match other "expand*" methods semantic, WDYT?{quote}

It sounds logical, but there is a CheckerFramework check that will complain if 
you make a private method non-static that could be static. So don't do it.

> Query with unqualified common column and NATURAL JOIN fails
> -----------------------------------------------------------
>
>                 Key: CALCITE-4915
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4915
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>              Labels: pull-request-available
>
> Query with unqualified common column and NATURAL JOIN:
> {noformat}
> SELECT deptno FROM emp NATURAL JOIN dept{noformat}
> Fails with "Column 'DEPTNO' is ambiguous" error.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to