[
https://issues.apache.org/jira/browse/CALCITE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220947#comment-17220947
]
Julian Hyde commented on CALCITE-4345:
--------------------------------------
OK, not minor. But changing private methods is allowed in a bug-fix like this.
A case in point: if you change {{boolean isIntLiteral(RexNode)}} to {{boolean
isNumericLiteralEqualTo(RexNode, BigDecimal)}} you can solve the problems with
NULL and overflow while keeping the code in {{transform}} nice and simple.
> SUM CASE WHEN xxx THEN 1 without "ELSE" throws NPE in
> AggregateCaseToFilterRule
> -------------------------------------------------------------------------------
>
> Key: CALCITE-4345
> URL: https://issues.apache.org/jira/browse/CALCITE-4345
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Jiatao Tao
> Assignee: Jiatao Tao
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2020-10-19-16-59-44-900.png
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Add a test in CsvTest:
>
> {code:java}
> @Test void testSumCaseWhenWithoutElse() throws SQLException {
> sql("model", "select sum( CASE WHEN empno=10 THEN 1 END ) from EMPS").ok();
> }
> {code}
> Will throw NPE
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
