[
https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chen updated CALCITE-4332:
--------------------------------
Description:
Current code in {{VolcanoPlanner}}:
{code:java}
assert RelOptUtil.equal(
"rel rowtype",
rel.getRowType(),
"equivRel rowtype",
equivRel.getRowType(),
Litmus.THROW);
equivRel = ensureRegistered(equivRel, null);
{code}
The suggested changes:
1) Use regular error {{IllegalArgumentException}} rather than an assertion
2) Make sure the exception message contains fine-grained information on what
went wrong. For instance: {{name: non nullable -> nullable; description:
character -> int; ...}}
was:
Current coed in {{VolcanoPlanner}}:
{code:java}
assert RelOptUtil.equal(
"rel rowtype",
rel.getRowType(),
"equivRel rowtype",
equivRel.getRowType(),
Litmus.THROW);
equivRel = ensureRegistered(equivRel, null);
{code}
The suggested changes:
1) Use regular error {{IllegalArgumentException}} rather than an assertion
2) Make sure the exception message contains fine-grained information on what
went wrong. For instance: {{name: non nullable -> nullable; description:
character -> int; ...}}
> Improve error when planning rule produces a relation with a wrong rowtype
> -------------------------------------------------------------------------
>
> Key: CALCITE-4332
> URL: https://issues.apache.org/jira/browse/CALCITE-4332
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.26.0
> Reporter: Vladimir Sitnikov
> Priority: Major
>
> Current code in {{VolcanoPlanner}}:
> {code:java}
> assert RelOptUtil.equal(
> "rel rowtype",
> rel.getRowType(),
> "equivRel rowtype",
> equivRel.getRowType(),
> Litmus.THROW);
> equivRel = ensureRegistered(equivRel, null);
> {code}
> The suggested changes:
> 1) Use regular error {{IllegalArgumentException}} rather than an assertion
> 2) Make sure the exception message contains fine-grained information on what
> went wrong. For instance: {{name: non nullable -> nullable; description:
> character -> int; ...}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
