[ 
https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090161#comment-17090161
 ] 

Junzheng Zheng commented on CALCITE-3932:
-----------------------------------------

I think use a private attribute of RelDataTypeFactory to hold the cache is OK 
since every query has its own RelDataTypeFactory . If we use threadLocal, a 
thread may be not correspoding to a query, e.q. if use a single thread to 
optimize all queries then the cache will be a global cache.

> Make data type cache thread local, non-evictable
> ------------------------------------------------
>
>                 Key: CALCITE-3932
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3932
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>             Fix For: 1.23.0
>
>
> Data type can be evicted out of cache, which is global, thread-safe. 
> It seems not necessary to cache them globally, because most of them are 
> RelRecordType, which is query dependent, not sharable between different 
> queries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to