[
https://issues.apache.org/jira/browse/CALCITE-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990801#comment-16990801
]
Hongze Zhang commented on CALCITE-3243:
---------------------------------------
Thanks for working on this issue [~wangm92] and [~zabetak]. And you might
already notice that CALCITE-2869 is more or less a blocker to this one.
Currently we don't ban 'SqlTypeFamily.ANY' as an operand type because JSON
functions accepts not only a plain string but also a
SqlJsonValueExpressionOprator[1], which is of return type 'SqlTypeFamily.ANY'.
In the fix of CALCITE-2869 we should ideally turn SqlJsonValueExpressionOprator
to return 'SqlTypeFamily.JSON' or something, then strengthen the operand
validation to solve this problem.
[1]
[https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/fun/SqlJsonValueExpressionOperator.java]
> Incomplete validation of operands in JSON functions
> -----------------------------------------------------
>
> Key: CALCITE-3243
> URL: https://issues.apache.org/jira/browse/CALCITE-3243
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.20.0
> Reporter: Stamatis Zampetakis
> Assignee: Matt Wang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The operands of various JSON functions are not validated correctly.
> Consider for instance the {{JSON_VALUE}} function and the following calls:
> {code:sql}
> json_value('{\"foo\":100}', 'strict $.foo')"
> json_value(1, 'strict $.foo')"
> json_value(TRUE, 'strict $.foo')"
> {code}
> The first call is legal but the next are not; if I am not wrong the operands
> should be always CHAR or VARCHAR literals which is not the case above.
> Queries involving such calls fail at runtime when compiling generated code. I
> guess that such kind of problems should be captured by the validator and we
> should not even arrive at the code generation step.
> The problems can be easily reproduced by adding such calls in the
> {{SqlOperatorBaseTest}}.
> The problem does not only affect {{JSON_VALUE}} but other JSON functions
> (such as {{JSON_QUERY}} etc.) as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
