[ 
https://issues.apache.org/jira/browse/CALCITE-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982248#comment-16982248
 ] 

Stamatis Zampetakis commented on CALCITE-3141:
----------------------------------------------

Let me summarize the state of the current PR:
* CalciteSystemProperty#TEST_SLOW is removed.
* @Tag("slow") (junit5 API) annotation is used to denote that a test is slow.
* A Gradle task (i.e., testSlow) has been added to conveniently run slow tests.
* A GitHub action is added to ensure that tests are run in CI (approximate 
duration ~1h20m).
* At the moment the action for slow tests runs for every commit in the master.
* A reviewer can explicitly trigger the action to run in a PR by adding the 
'slow-tests-needed' label.

Let me know if you are OK with the changes above and if there is something else 
that needs to be done (cc [~vlsi]).

> Slow tests are not run in continuous integration
> ------------------------------------------------
>
>                 Key: CALCITE-3141
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3141
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.19.0, 1.20.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>             Fix For: 1.22.0
>
>
> Trying to execute slow tests locally always ends up with failures and these 
> failures are not reflected in continuous integration (Jenkins, AppVeyor, 
> Travis).
>  
> From the CI configuration below (extract from the logs) this appears normal 
> for Jenkins and AppVeyor but not for Travis.
>  
> *Jenkins:*
> /home/jenkins/tools/maven/apache-maven-3.3.3/bin/mvn -f ws/pom.xml 
> "-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/Calcite-Master/jdk/JDK
>  1.8 (latest)/label_exp/ubuntu&&!cloud-slave&&!H27/.repository" clean install 
> javadoc:javadoc -DskipITs -B
>  
> *Travis:*
> $ if [ $SLOW_TESTS = "Y" ]; then export 
> TESTS="-Dgroups=org.apache.calcite.test.SlowTests --projects :calcite-core"; 
> else export TESTS=-DskipSlowTests; fi
> The command "if [ $SLOW_TESTS = "Y" ]; then export 
> TESTS="-Dgroups=org.apache.calcite.test.SlowTests --projects :calcite-core"; 
> else export TESTS=-DskipSlowTests; fi" exited with 0.
>  
> *AppVeyor:*
> mvn -Dcheckstyle.skip -Dsurefire.useFile=false -Dsurefire.threadCount=1 
> -Dsurefire.perCoreThreadCount=false 
> -Djavax.net.ssl.trustStorePassword=changeit test -Djna.nosys=true



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to