[
https://issues.apache.org/jira/browse/CALCITE-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974834#comment-16974834
]
Xiening Dai commented on CALCITE-3491:
--------------------------------------
Yes, you can open a JIRA. From what I can tell, the other places using "if
(true)" are more or less like place holders. They don't short circuit the
entire function, and are not as confusing as this one.
> VolcanoPlanner.completeConversion() is bypassed by "if (true)"
> --------------------------------------------------------------
>
> Key: CALCITE-3491
> URL: https://issues.apache.org/jira/browse/CALCITE-3491
> Project: Calcite
> Issue Type: Bug
> Reporter: Xiening Dai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Not very clear about why we need VolcanoPlanner.completeConversion(). It's
> currently bypassed as below[1] -
> if (true) {
> return rel;
> }
> If the method is not needed, we should just remove it.
> [1]
> https://github.com/apache/calcite/blob/f90e5d7b48848191c1a70e6c0f78eece93433806/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java#L1096
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
