[
https://issues.apache.org/jira/browse/CALCITE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930783#comment-16930783
]
Julian Hyde commented on CALCITE-3340:
--------------------------------------
Well, the PR doesn't do quite what the JIRA case promises. You've added a table
function called "TUMBLE_TABLE_FUNCTION" not "TUMBLE".
I see a couple of spurious changes in formatting, and a lot of classes, methods
and fields added with no javadoc. Without javadoc it's difficult to know the
intent of this code.
> Make TUMBLE be accepted as an operand for COLLECTION_TABLE(TABLE syntax) in
> validator
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-3340
> URL: https://issues.apache.org/jira/browse/CALCITE-3340
> Project: Calcite
> Issue Type: Sub-task
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
>
> For query:
> SELECT *
> FROM TABLE(TUMBLE(
> TABLE ORDERS,
> DESCRIPTOR(ROWTIME),
> INTERVAL '10' MINUTE))
> (note reuse TUMBLE operator than use a new unresolved one)
> Calcite validator will does a step to do registration and
> "TABLE(TUMBLE(...))" will hit [1], where "TUMBLE(...)" will be passed to [2]
> again but there is no matching Sqlkind handling for "TUMBLE" (note that
> TUMBLE's node kind is TUMBLE).
> It seems we should support TUMBLE in [2]. The details of how to support it
> needs a bit more discussion and prototyping.
> [1]:
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2244
> [2]:https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2031
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
