[ 
https://issues.apache.org/jira/browse/CALCITE-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913790#comment-16913790
 ] 

Ryan Fu commented on CALCITE-3280:
----------------------------------

Hi [~lishuming], I was originally going to work on this but glad you were able 
to help contribute.

As for adding in variants of `REGEXP_REPLACE`, I would say it would be 
desirable but not necessary. One thing I would add in your pull request is a 
comment about your `LibraryOperator` to describe the functionality of 
`REGEXP_REPLACE`


{code:java}
/** The REGEXP_REPLACE(source_string, pattern, replacement) searches for a 
regular expression pattern and replaces every occurrence of the pattern with 
the specified string */
{code}

> Cannot parse query REGEXP_REPLACE in Redshift
> ---------------------------------------------
>
>                 Key: CALCITE-3280
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3280
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Ryan Fu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> REGEXP_REPLACE error:
> {code:}
> No match found for function signature REGEXP_REPLACE(<CHARACTER>, 
> <CHARACTER>, <CHARACTER>){code}
>  
> Example query:
> {code:sql}
> SELECT * , MD5(TRIM(BOTH ' ' FROM REGEXP_REPLACE(LOWER(name), 
> '([[:space:]]|,)+([iInNcC]|[lLcC]).*$', ''))) AS company_id FROM 
> public.account {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to