[
https://issues.apache.org/jira/browse/CALCITE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde reopened CALCITE-2944:
----------------------------------
Re-opening. I still see a bunch of deprecation warnings:
{noformat}
[WARNING]
druid/src/main/java/org/apache/calcite/adapter/druid/DruidQuery.java:[476,27]
indicator in org.apache.calcite.rel.core.Aggregate has been deprecated
[WARNING]
druid/src/main/java/org/apache/calcite/adapter/druid/DruidRules.java:[448,20]
indicator in org.apache.calcite.rel.core.Aggregate has been deprecated
[WARNING]
druid/src/main/java/org/apache/calcite/adapter/druid/DruidRules.java:[495,20]
indicator in org.apache.calcite.rel.core.Aggregate has been deprecated
[WARNING]
druid/src/main/java/org/apache/calcite/adapter/druid/DruidRules.java:[607,24]
indicator in org.apache.calcite.rel.core.Aggregate has been deprecated
[WARNING]
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchRules.java:[272,16]
indicator in org.apache.calcite.rel.core.Aggregate has been deprecated
[WARNING]
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchAggregate.java:[62,5]
Aggregate(org.apache.calcite.plan.RelOptCluster,org.apache.calcite.plan.RelTraitSet,org.apache.calcite.rel.RelNode,boolean,org.apache.calcite.util.ImmutableBitSet,java.util.List<org.apache.calcite.util.ImmutableBitSet>,java.util.List<org.apache.calcite.rel.core.AggregateCall>)
in org.apache.calcite.rel.core.Aggregate has been deprecated{noformat}
Our policy is that there should be zero warnings. Which means we either stop
using APIs we have deprecated, or we insert comments/annotations to silence the
warnings.
> Deprecate Aggregate indicators and remove fields where possible
> ---------------------------------------------------------------
>
> Key: CALCITE-2944
> URL: https://issues.apache.org/jira/browse/CALCITE-2944
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Attachments: image-2019-03-21-18-19-58-933.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Although Aggregate.indicator is discouraged to use, but no test cases
> guarantee indicator can work correctly. I tried to set indicator to always
> false in Aggregate constructor, it passed all the tests.
> !image-2019-03-21-18-19-58-933.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
