[ 
https://issues.apache.org/jira/browse/CALCITE-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618009#comment-16618009
 ] 

Julian Hyde commented on CALCITE-1894:
--------------------------------------

The {{lines}} parameter, which is assigned to the {{skipLines}} field, is 
intended to be the mechanism by which header lines (if any) are skipped. But it 
is not used.

I'm not sure whether the {{Thread.sleep}} is also a problem. It probably is.  A 
delay is fine, but it should loop until it has read and discarded at least 
{{skipLines}} of data, and only then start emitting results.

I think {{contentQueue}} is probably still the right approach. It is a 
{{ArrayDeque}} but is used from a single thread so is safe.

> CsvTest.testCsvStream failing often
> -----------------------------------
>
>                 Key: CALCITE-1894
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1894
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Julian Hyde
>            Priority: Major
>
> CsvTest.testCsvStream is timing out and failing often.
> This is the build failed because of this test.
> https://travis-ci.org/apache/calcite/jobs/253794426
> {noformat}
> <<< FAILURE! - in org.apache.calcite.test.CsvTest
> testCsvStream(org.apache.calcite.test.CsvTest)  Time elapsed: 10.044 sec  <<< 
> ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 10000 
> milliseconds
>       at org.apache.calcite.test.CsvTest.testCsvStream(CsvTest.java:729)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to