[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615364#comment-16615364
]
Zoltan Haindrich commented on CALCITE-2555:
-------------------------------------------
[~vladimirsitnikov] you have run your freaking checks on what version????? I've
just checked it with *your original example* because I wanted to know where I
was wrong...but now I'm seeing that the code have produced what I described
....you've either executed the patched version or you have just run your test
against some rougue branch which didn't even contained it...
I think it would be better to have it at least at the end of simplify_() -
because after that the recursion can be removed which would remove the current
extra weight it adds...right now it "only" does a full subtree node scan on
invocations ...(which would need a wide tree for impact...)
I still think that adding it as an orthogonal logic is not the best option.
but you know...I'm just a nobody...just commit what you think is right...
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
