[
https://issues.apache.org/jira/browse/CALCITE-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612869#comment-16612869
]
Julian Hyde edited comment on CALCITE-2504 at 9/12/18 11:55 PM:
----------------------------------------------------------------
* In the class name can you correct "Programm" to "Program"
* When you initialize arrays, can you use the abbreviated form "Foo[] foos = \{
... ]}" rather than "Foo[] foos = new Foo[] \{ ... \}".
* I do think you should add it to the standard suite, even now while things are
flaky. Because if code is not run then it breaks. Run it with a fixed seed and
(small) iteration count so that there are no failures.
* I think you should remove the class name from the commit message. It is
possible to describe the test in terms that someone who has not read the code
would understand.
was (Author: julianhyde):
* In the class name can you correct "Programm" to "Program"
* When you initialize arrays, can you use the abbreviated form "Foo[] foos = {
... }" rather than "Foo[] foos = new Foo[] { ...}".
* I do think you should add it to the standard suite, even now while things are
flaky. Because if code is not run then it breaks. Run it with a fixed seed and
(small) iteration count so that there are no failures.
* I think you should remove the class name from the commit message. It is
possible to describe the test in terms that someone who has not read the code
would understand.
> RexProgrammFuzzyTest: fuzzer for RexNodes
> -----------------------------------------
>
> Key: CALCITE-2504
> URL: https://issues.apache.org/jira/browse/CALCITE-2504
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
