[
https://issues.apache.org/jira/browse/CALCITE-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582824#comment-16582824
]
Julian Hyde commented on CALCITE-2469:
--------------------------------------
Can you rebase that pull request, please. It currently shows 9 commits, and I'm
not sure which ones you intend to contribute.
Be careful with comments like {code}// not(x) is null should not optimized to x
is not null{code}. Without quotes or capitalization they are difficult to read.
Also, don't bother with comments that say what the code is NOT doing. The
commit log (and JIRA) will tell that store. Document what is the right thing
(and, if absolutely necessary, briefly explain why it's the right thing).
> RexSimplify should not optimize 'not(x) is null' to 'x is not null
> ------------------------------------------------------------------
>
> Key: CALCITE-2469
> URL: https://issues.apache.org/jira/browse/CALCITE-2469
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: pengzhiwei
> Assignee: Julian Hyde
> Priority: Critical
>
> The RexSimplify will optimize the 'not（x) is null' to 'x is not null'.
> However,this is incorrect.It is same to the case 'not（x） is not null' .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
