[
https://issues.apache.org/jira/browse/CALCITE-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964962#comment-15964962
]
Michael Mior commented on CALCITE-1752:
---------------------------------------
I'm not sure a utility is necessary since it's just a single static method call
and the functionality is in the standard library. I think in this case adding a
utility just obfuscates things unless there's a reason I'm not seeing where
we're likely to want to change this behaviour in the future.
> Use URLDecoder#decode to handle URLs acquired from getResource(..) calls in
> test cases
> --------------------------------------------------------------------------------------
>
> Key: CALCITE-1752
> URL: https://issues.apache.org/jira/browse/CALCITE-1752
> Project: Calcite
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Fix For: avatica-1.10.0, 1.13.0
>
>
> From
> https://github.com/apache/calcite/commit/6543c0fd8b63efb00d035790209f8546668d7aa5#commitcomment-21723380:
> [~michaelmior] suggested that it would be better to replace my
> {{String.replace("%20", " ")}} with {{java.net.URLDecoder.decode}} instead. I
> am apt to agree with him :)
> Maybe we can pull this into a utility instead of littering it around test
> cases in avatica and calcite.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
