[ 
https://issues.apache.org/jira/browse/BEAM-8910?focusedWorklogId=445025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445025
 ]

ASF GitHub Bot logged work on BEAM-8910:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/20 16:29
            Start Date: 12/Jun/20 16:29
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r439522134



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -78,6 +72,12 @@
 or a table. Pipeline construction will fail with a validation error if neither
 or both are specified.
 
+When reading from BigQuery using `BigQuerySource`, bytes are returned as
+base64-encoded bytes. When reading via `ReadFromBigQuery`, bytes are returned
+as bytes without base64 encoding. This is due to the fact that ReadFromBigQuery
+uses Avro expors by default. To get base64-encoded bytes, you can use the flag

Review comment:
       nit: exports

##########
File path: CHANGES.md
##########
@@ -58,6 +58,10 @@
 
 * Support for X source added (Java/Python) 
([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
 * Support for reading from Snowflake added (Java) 
([BEAM-9722](https://issues.apache.org/jira/browse/BEAM-9722)).
+* A new transform to read from BigQuery has been added: 
`apache_beam.io.gcp.bigquery.ReadFromBigQuery`. This transform

Review comment:
       To confirm - there is no changes in behavior for old sync, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 445025)
    Time Spent: 17h  (was: 16h 50m)

> Use AVRO instead of JSON in BigQuery bounded source.
> ----------------------------------------------------
>
>                 Key: BEAM-8910
>                 URL: https://issues.apache.org/jira/browse/BEAM-8910
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Kamil Wasilewski
>            Priority: P3
>          Time Spent: 17h
>  Remaining Estimate: 0h
>
> The proposed BigQuery bounded source in Python SDK (see PR: 
> [https://github.com/apache/beam/pull/9772)] uses a BigQuery export job to 
> take a snapshot of the table and read from each produced JSON file. A 
> performance improvement can be gain by switching to AVRO instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to