[
https://issues.apache.org/jira/browse/BEAM-10003?focusedWorklogId=438337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438337
]
ASF GitHub Bot logged work on BEAM-10003:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/20 16:44
Start Date: 28/May/20 16:44
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #11796:
URL: https://github.com/apache/beam/pull/11796#issuecomment-635462639
> @pabloem What is the point of having the code_sample directive in the
first place? Wouldn't it be clearer and easier to edit documentation if all
code samples are inline in the markdown itself?
We can run unit tests against snippets coming from source code files. That
prevent snippets from having issues or getting out of sync with rest of the
code. It is not straightforward to do the same thing with inlined code samples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 438337)
Time Spent: 3h (was: 2h 50m)
> Need two PR to submit snippets to website
> -----------------------------------------
>
> Key: BEAM-10003
> URL: https://issues.apache.org/jira/browse/BEAM-10003
> Project: Beam
> Issue Type: New Feature
> Components: website
> Reporter: Reza ardeshir rokni
> Assignee: Aizhamal Nurmamat kyzy
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Looks like build_github_samples.sh uses code already on the repo to build
> local serving;
> do
> fileName=$(echo "$url" | sed -e 's/\//_/g')
> curl -o "$DIST_DIR"/"$fileName"
> "[https://raw.githubusercontent.com|https://raw.githubusercontent.com/]$url";
> done
> So when tying to test locally, the code needs to have already be in Beam.
> Ideally the script should make use of local code when building so :
> 1- Easier to build & test changes.
> 2- No need to raise two PR for what is a single change
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
