[
https://issues.apache.org/jira/browse/BEAM-10077?focusedWorklogId=437441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437441
]
ASF GitHub Bot logged work on BEAM-10077:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 03:50
Start Date: 27/May/20 03:50
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#11813:
URL: https://github.com/apache/beam/pull/11813#discussion_r430505636
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -211,8 +210,8 @@
@VisibleForTesting static final int GCS_UPLOAD_BUFFER_SIZE_BYTES_DEFAULT =
1024 * 1024;
- @VisibleForTesting static final String PIPELINE_FILE_FORMAT =
"pipeline-%s.pb";
- @VisibleForTesting static final String DATAFLOW_GRAPH_FILE_FORMAT =
"dataflow_graph-%s.json";
+ @VisibleForTesting static final String PIPELINE_FILE_NAME = "pipeline.pb";
Review comment:
Seems like this is just reverting to old behavior. Why would these names
being unique an issue ? Did the change break Dataflow somehow ?
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -264,6 +259,14 @@ public static Environment createProcessEnvironment(
.build()
.toByteString());
}
+ if (stagedName == null) {
+ stagedName = createStagingFileName(file, hashCode);
Review comment:
Where are we setting the hashCoder for this path ? Also are we missing a
unit test for this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 437441)
Time Spent: 40m (was: 0.5h)
> using filename + hash instead of UUID for staging name
> ------------------------------------------------------
>
> Key: BEAM-10077
> URL: https://issues.apache.org/jira/browse/BEAM-10077
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Fix For: 2.22.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Recent change BEAM-9383 disabled the artifact caching logic for GCS by object
> names. Changing staging name generation from UUID to filename + hash will
> re-enable the artifact caching so we can avoid re-uploading same artifact.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
