[
https://issues.apache.org/jira/browse/BEAM-8910?focusedWorklogId=429547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429547
]
ASF GitHub Bot logged work on BEAM-8910:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/20 16:27
Start Date: 01/May/20 16:27
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r418609817
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -45,8 +45,8 @@
may use some caching techniques to share the side inputs between calls in order
to avoid excessive reading:::
- main_table = pipeline | 'VeryBig' >> beam.io.Read(beam.io.BigQuerySource()
- side_table = pipeline | 'NotBig' >> beam.io.Read(beam.io.BigQuerySource()
+ main_table = pipeline | 'VeryBig' >> beam.io.ReadFroBigQuery(...)
Review comment:
Typo in From
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -78,6 +72,12 @@
or a table. Pipeline construction will fail with a validation error if neither
or both are specified.
+When reading from BigQuery using `BigQuerySource`, bytes are returned as
Review comment:
Can we add some guidance when to use which?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 429547)
Time Spent: 9h 40m (was: 9.5h)
> Use AVRO instead of JSON in BigQuery bounded source.
> ----------------------------------------------------
>
> Key: BEAM-8910
> URL: https://issues.apache.org/jira/browse/BEAM-8910
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Kamil Wasilewski
> Assignee: Pablo Estrada
> Priority: Minor
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> The proposed BigQuery bounded source in Python SDK (see PR:
> [https://github.com/apache/beam/pull/9772)] uses a BigQuery export job to
> take a snapshot of the table and read from each produced JSON file. A
> performance improvement can be gain by switching to AVRO instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
