[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=426374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426374
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/20 05:23
Start Date: 23/Apr/20 05:23
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #11472:
URL: https://github.com/apache/beam/pull/11472#discussion_r413517743
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnInvoker.java
##########
@@ -94,9 +94,13 @@ void invokeOnTimer(
void invokeSplitRestriction(ArgumentProvider<InputT, OutputT> arguments);
/**
- * Invoke the {@link DoFn.GetSize} method on the bound {@link DoFn}. Falls
back to get the size
- * from the {@link RestrictionTracker} if it supports {@link Sizes.HasSize},
otherwise returns
- * 1.0.
+ * Invoke the {@link DoFn.GetSize} method on the bound {@link DoFn}. Falls
back to:
+ *
+ * <ol>
+ * <li>get the work remaining from the {@link RestrictionTracker} if it
supports {@link
+ * HasProgress}.
+ * <li>returning the constant {@link 1.0}.
Review comment:
This is an internal comment for the implementation here.
The user having comments are in DoFn.java and RestrictionTracker.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 426374)
Time Spent: 30h (was: 29h 50m)
> Fn API SDF support
> ------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 30h
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
